Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 path doesn't work with annotations #2330

Open
soulgalore opened this issue Feb 21, 2019 · 0 comments
Open

S3 path doesn't work with annotations #2330

soulgalore opened this issue Feb 21, 2019 · 0 comments
Labels
bug s3 AWS S3

Comments

@soulgalore
Copy link
Member

As reported in #2329

When trying to implement the path option that exists in S3 and also sending annotations to Graphite the resultUrls is completely ignoring the path option giving me:

INFO: [sitespeedio] Find the result at https://storage.googleapis.com/bucketname/www.my-domain.com/2019-02-21-10-49-01

Instead of (setting path to my-sub-folder/test1):

INFO: [sitespeedio] Find the result at https://storage.googleapis.com/bucketname/my-sub-folder/test1

This gives wrong urls in the annotations.

I do not have the possibility to test the S3 storage plugin but to me it looks like the same problem exists there? I have also inspected the message in the Graphite plugin and cant find any info about the path in there and also the Graphite plugin looks like it is run before storing the results in S3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug s3 AWS S3
Projects
None yet
Development

No branches or pull requests

1 participant