Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to gracefully stop sitespeed task with correct report generation #3808

Open
S0bakaRU opened this issue Apr 6, 2023 · 1 comment

Comments

@S0bakaRU
Copy link

S0bakaRU commented Apr 6, 2023

Feature/improvement

It would be great to have a possibility to gracefully interrupt the execution of a multi-iteration test at an arbitrary time.
Or the possibility to run sitespeed iterations based on some predefined time duration, not iteration counter.
It is important that after a "stop signal" is received, the current iteration ends correctly and sitespeed calculates the final reports based on the completed iterations.

Typical possible scenario:

Run sitespeed with --browsertime.iterations = 1000 in parallel with some load tests with indefinite duration and need to interrupt sitespeed when load test will be finished with final report generation based on really passed iterations.

It would be great to have the possibility to initiate the mentioned "stopping" action in some common automation-friendly way: like sending a custom linux signal, or setting some control file or another "flag" (similar way as it is realised for dashbaoard.sitespeed.io).

@soulgalore
Copy link
Member

This would be cool, but I think it's hard to implement? A terminate signal could send the correct messages on the queue (signal that everything is done) but we need to clean up/stop the browser. A first step would be to try to implement this in Browsertime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants