Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's no option to pass touches to the underlaying controller #48

Closed
4 of 9 tasks
natalia-osa opened this issue Sep 13, 2019 · 3 comments
Closed
4 of 9 tasks

Comments

@natalia-osa
Copy link

natalia-osa commented Sep 13, 2019

Description

If you want to allow the user to interact both with the presenting view controller and the presented view controller, it's impossible currently. Eg if you treat the library as card presenter, you often want to allow the user to interact eg with the map above (example: Google Maps).
Another example is using the library as a notification panel. I believe in most situations you don't want to block the user interface for those 5s (or different value) as the notification is visible.

What type of issue is this?

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@ste57
Copy link
Contributor

ste57 commented Sep 22, 2019

Hi @natalia-osa

Thank you for the request. We have thought about supporting pass-through touches within PanModal but ultimately made the decision to keep it lightweight. We are not planning to work on any new features for the library, in the short term, but we may look to add this to our future roadmap.

However, if you feel this is something you need, we encourage forking the library and adding necessary changes.

Thanks,
Stephen

@natalia-osa
Copy link
Author

Hi,

Thanks for letting me know. I've finally ended with FloatingPanel library, which fulfills those requirements.

Thanks,
Natalia

@ste57 ste57 closed this as completed Oct 1, 2019
@osdnk
Copy link

osdnk commented Feb 29, 2020

Hi all,
I did it in my lib somehow (my lib is exporting bindings to RN)
A bit hacky but it works ¯_(ツ)_/¯
osdnk/react-native-slack-bottom-sheet@e72d5f1#diff-872ed152deaa4ed95fc370b34abb753eR107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants