oasfilter IndexView contains duplicate annotations

[Postremus]

I have an OASFilter which uses the provided IndexView:

    private final IndexView index;

    public WolfOASFilterImpl(IndexView index) {
        this.index = index;
    }

While scanning through the index using e.g. index.getAnnotations(Annotation.class), I get the AnnotationInstance's returned duplicated.

https://smallrye.io/blog/jandex-3-2-0/
Jandex has a stacked index view, which only returns the first result.

[MikeEdgar]

I see how this could happen and yes, a StackedIndexed would help. I'm curious which annotation is giving you duplicates? My guess would be one of the MP OpenAPI annotations, but I just want to confirm.

[Postremus]

actually, it is an annotation from our custom security framework (dont ask..).

We annotate our resource methods like this:

@Allow({"user_mange", "user_read"})
@GET
public User read(...) {
...
}

In my OASFilter, I match all declarations of @Allow to their coresponding location in the openapi document using the methodref (and generate security requirements, api responses, and operation descriptions)
I retrieve the declarations using index.getAnnotations(Allow.class), which returns duplicates.

If I remember correctly, i worked around this problem by wrapping the annotationinstances in a HashSet.

[MikeEdgar]

Oh that's interesting. Do you know what Jandex version the runtime you're using includes? Or are you using either the Maven or Gradle plugin?

The reason is that if the runtime (e.g. Quarkus) is passing a composite index to smallrye-open-api, then using the stacked index here will not help.

[Postremus]

Quarkus 3.18.2

If I remember correctly, i worked around this problem by wrapping the annotationinstances in a HashSet.

I just looked at the code again, I use a Map<String, MethodInfo> operationMethods, where the key is the methodref to filter out duplicates.

[MikeEdgar]

It looks like Quarkus 3.18 may still be using the CompositeIndex itself, which would be passed to the OpenAPI scanner as well. Until that's updated (if it's even planned) there may not be much we can do about it in this project.