Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Unifying how topological change are handled in mappings. #223

Open
damienmarchal opened this issue Mar 31, 2017 · 0 comments
Open
Assignees
Labels
enhancement About a possible enhancement

Comments

@damienmarchal
Copy link
Contributor

damienmarchal commented Mar 31, 2017

In PR #217

#ifdef BARYCENTRIC_MAPPER_TOPOCHANGE_REINIT
    // handle topology changes in the From topology
    virtual void handleTopologyChange(core::topology::Topology* t);
#endif // BARYCENTRIC_MAPPER_TOPOCHANGE_REINIT

Is coding to change to runtime condition instead of #IFDEF.

@JeremieA pointed that this rise consistency issues in how the topology changes are handled into the mapping.

Maybe we should keep that in mind and in some future do something (eg making a test that should be done all mapping to validate a consistent and clear behavior).

@damienmarchal damienmarchal changed the title In PR https://github.com/sofa-framework/sofa/pull/217/files. [all] Unifying how topological change are handled in mappings. Mar 31, 2017
@damienmarchal damienmarchal added the enhancement About a possible enhancement label Mar 31, 2017
@epernod epernod self-assigned this May 16, 2018
@epernod epernod added this to the v18.12 milestone May 16, 2018
@epernod epernod modified the milestones: v18.12, v19.12 Mar 5, 2019
@guparan guparan removed this from the v19.12 milestone Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement
Projects
None yet
Development

No branches or pull requests

3 participants