Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path resolver failes #67

Open
rainerhahnekamp opened this issue Feb 13, 2024 · 4 comments
Open

Path resolver failes #67

rainerhahnekamp opened this issue Feb 13, 2024 · 4 comments
Assignees
Milestone

Comments

@rainerhahnekamp
Copy link
Collaborator

    "paths": {
      "@app/*": ["apps/eternal/src/app/*"],
      "@app/customers/api": ["libs/customers/api/src/index.ts"],
      "@app/customers/data": ["libs/customers/data/src/index.ts"],
      "@app/customers/feat-main": ["libs/customers/feat-main/src/index.ts"],
      "@app/customers/model": ["libs/customers/model/src/index.ts"],
      "@app/customers/ui": ["libs/customers/ui/src/index.ts"],
      "@app/holidays/api": ["libs/holidays/api/src/index.ts"],
      "@app/holidays/data": ["libs/holidays/data/src/index.ts"],
      "@app/holidays/feat-brochure": [
        "libs/holidays/feat-brochure/src/index.ts"
      ],

Will always fail because the path resolver stops at the first and doesn't continue.

@bradley-carestia-jbh
Copy link

bradley-carestia-jbh commented Jul 1, 2024

Seems to not work on wildcard paths in general, saying "libs/libName/*/src/index.ts" does not exist. This means that it can't be used for secondary entry-points, which IMO is the primary benefit of this lib in an Nx repo (where we can otherwise use Nx module boundaries)

@rainerhahnekamp rainerhahnekamp self-assigned this Jul 1, 2024
@rainerhahnekamp
Copy link
Collaborator Author

@bradley-carestia-jbh is this the same as #17?

@bradley-carestia-jbh
Copy link

Looks like it, yes!

@rainerhahnekamp rainerhahnekamp added this to the Cache milestone Jul 2, 2024
@rainerhahnekamp
Copy link
Collaborator Author

Okay, that should be covered with the Caching Milestone.

Currently, the algorithm reads every file separately, which makes wildcards inefficient. With the cache, we load all files and, therefore, have full knowledge of the existing files and directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants