Esbonio build fails with WinError 2: File in use error when renaming temporary file

[JensWalther]

https://github.com/sphinx-contrib/plantuml/blame/09f9d13c44bdbfb73974159cedd29bb1d2e08f69/sphinxcontrib/plantuml.py#L411

This close statement is "double" closing the temporary file causing the rename to fail occasionally. Observed with v.29 wheel file.

v.26 does not show this error.

[JensWalther]

The rename must happen behind the 'with' block as the explicit close inside the with block is incorrect and can cause undefined behavior such as the file not being closed. This causes the rename to fail

[xfornari]

I observe the same (v.30) and had to go back to v.26 as JensWalther mentionned (running on Windows)

[marcel-22]

I experience a similar problem. Will try version 0.26 and see if this "fixes" the issue. (Running on Windows as well.)

[marcel-22]

I just ran in the same problem, but this time with version 0.26 in the virtual environment:
sphinx-build failed: PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\abc\\AppData\\Local\\swyddfa\\esbonio\\Cache\\3cefb5b74a7a3d678c944fd250a2f243\\html\\_plantuml\\24\\2495a68de906b7f3bdc7678609d82b721d5c87b1.png.new' -> 'C:\\Users\\abc\\AppData\\Local\\swyddfa\\esbonio\\Cache\\3cefb5b74a7a3d678c944fd250a2f243\\html\\_plantuml\\24\\2495a68de906b7f3bdc7678609d82b721d5c87b1.png'

Note: It concerns a multi-root workspace.

[etainardi]

Look at the issue I opened two weeks ago, the devs aren't functioning so tweaked the code myself and now it works.. written the modified code in my issue thread