Consolidate on Criteria or Divan for benchmarking

[gatesn]

No description provided.

[AdamGS]

My 2c here - I wished I could fork Criterion multiple times, and it seems like Divan is actually maintained which is a big plus in my book

[robert3005]

I agree with your point. Seeing criterion have 23 open prs is not a good look for a project with a well defined functionality

[gatesn]

Only issue I see atm is that Divan doesn't support async benchmarks? Any ideas how to workaround @AdamGS ?

[AdamGS]

The first thing I would try is to create the runtime as part of the setup, and then call Runtime::block_on or it's equivalent in the actual benchmark code.
From reading the docs seems like there are some threading-related configs you might have to use, and hopefully everything will play nice together.

[nvzqz]

Hi! I plan to prioritize async benchmarks after I ship JSON output. 🙂 Follow nvzqz/divan#39 for updates

From reading the docs seems like there are some threading-related configs you might have to use, and hopefully everything will play nice together.

That's separate and unrelated from async. Multi-threaded benchmarks are more so for measuring contention on locks and atomics.