Skip to content

Hash diff duplicates lines #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nakilon opened this issue May 20, 2025 · 2 comments
Open

Hash diff duplicates lines #285

Nakilon opened this issue May 20, 2025 · 2 comments

Comments

@Nakilon
Copy link

Nakilon commented May 20, 2025

I wonder why this issue remains since 0.9.0

      expect({1=>2, 2=>3, 3=>4}).to eq({3=>1, 2=>3, 1=>3})
         {
       -   1 => 3
       +   1 => 2,
           2 => 3,
       -   1 => 3
       -   3 => 1,
       +   3 => 4
         }

The amount of duplicating lines can be enormous.

@Nakilon
Copy link
Author

Nakilon commented May 20, 2025

Looks like I just provided a simple example to reproduce #99

Instead of fixing real issues we do stuff like bumping required_ruby_version for no reason. Probably just to make the gem not runnable at all so bug won't happen.

@jas14
Copy link
Collaborator

jas14 commented May 21, 2025

@Nakilon , thanks for the small repro case, that will be very helpful for debugging!

Instead of fixing real issues we do stuff like bumping required_ruby_version for no reason. Probably just to make the gem not runnable at all so bug won't happen.

I understand this bug is frustrating, but please practice empathy. Information that can help us identify and solve the issue is really useful; saying things like what I've quoted is not. (And of course, if you can find the bug before we do, feel free to open a PR!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants