Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldValuesParser implementation for the eclipse compiler #2289

Open
snicoll opened this issue Jan 6, 2015 · 5 comments
Open

FieldValuesParser implementation for the eclipse compiler #2289

snicoll opened this issue Jan 6, 2015 · 5 comments
Labels
type: enhancement A general enhancement

Comments

@snicoll
Copy link
Member

snicoll commented Jan 6, 2015

When running the build with the eclipse compiler, the default values cannot be harvested and written in the meta-data because there is no suitable implementation of FieldValuesParser.

@snicoll snicoll added the type: enhancement A general enhancement label Jan 6, 2015
@philwebb
Copy link
Member

philwebb commented Jan 6, 2015

This is because the eclipse compiler is different from the JDK one. Some of the initial FieldValuesParser work was based on things that lombok does, they have an eclipse equivalent so perhaps we can use a similar technique.

@snicoll
Copy link
Member Author

snicoll commented Nov 25, 2016

Duplicates #7226 - We'll have to find another technique for Java 9 anyway and that one should be compiler independent.

@snicoll snicoll closed this as completed Nov 25, 2016
@snicoll snicoll added status: duplicate A duplicate of another issue and removed type: enhancement A general enhancement labels Nov 25, 2016
@philwebb
Copy link
Member

Reopening to check that e15b3e4 actually fixed this.

@philwebb philwebb added type: enhancement A general enhancement and removed status: duplicate A duplicate of another issue labels Nov 28, 2016
@philwebb philwebb reopened this Nov 28, 2016
@snicoll
Copy link
Member Author

snicoll commented Nov 29, 2016

It did not, good catch. I am still discussing with the openjdk team to find a better way to deal with this.

@hansenc
Copy link

hansenc commented Feb 20, 2020

For anyone else running into it, this also affects errorprone's javac (from their JDK 8 instructions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants