Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of RabbitConnectionFactoryBean.setUri() #3328

Open
wilkinsona opened this issue Jun 25, 2015 · 3 comments
Open

Make use of RabbitConnectionFactoryBean.setUri() #3328

wilkinsona opened this issue Jun 25, 2015 · 3 comments
Labels
type: enhancement A general enhancement

Comments

@wilkinsona
Copy link
Member

#2944 (comment)

@garyrussell garyrussell changed the title Make use of RabbitConnectionFactory.setUri() Make use of RabbitConnectionFactoryBean.setUri() Jun 25, 2015
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2015
@wilkinsona wilkinsona removed the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2015
@GurinderSinghBrar
Copy link

GurinderSinghBrar commented Jan 18, 2018

I have used ConnectionFactory instead of RabbitConnectionFactoryBean in possible solution.

URI uriObject = new URI(input);
com.rabbitmq.client.ConnectionFactory factory = new com.rabbitmq.client.ConnectionFactory();
factory.setUri(uri);
this.username = uriObject.getUserInfo().split(":")[0]);
this.password = uriObject.getUserInfo().split(":")[1]);
this.virtualhost = uriObject.getPath();

@philwebb philwebb added this to the Backlog milestone Mar 22, 2018
@bclozel bclozel modified the milestones: Backlog, Icebox Aug 22, 2018
@ayudovin
Copy link
Contributor

ayudovin commented Sep 9, 2018

@wilkinsona, Should new property uri be added in RabbitProperties ?

@wilkinsona
Copy link
Member Author

@ayudovin We've backed ourselves into a bit of a corner with Rabbit's configuration. We currently treat the addresses property in a somewhat similar way to how Rabbit treats a URI in that we parse various things out of it (although only from the first address when there's more than one), whereas Rabbit expects address to just be a host:port pair. RabbitProperties' addresses property should really align with Rabbit and only take host:port pairs. We could then add a new uri property. I'm not sure how we get from where we are now to where we want to be as it will be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

7 participants