Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate JarFileEntries index entry #5668

Open
philwebb opened this issue Apr 12, 2016 · 1 comment
Open

Investigate JarFileEntries index entry #5668

philwebb opened this issue Apr 12, 2016 · 1 comment
Labels
theme: performance Issues related to general performance type: enhancement A general enhancement

Comments

@philwebb
Copy link
Member

The JarFileEntries is used as the index for a Jar file and is constructed when the file is loaded. We could probably compute it during repackage and save as an entry. This might make loading the zips faster.

@philwebb philwebb added the type: enhancement A general enhancement label Apr 12, 2016
@philwebb philwebb added this to the 1.4.0.M3 milestone Apr 12, 2016
@philwebb philwebb modified the milestones: 1.4.0.M3, 1.4.0.RC1 May 10, 2016
@Turbots
Copy link

Turbots commented May 24, 2016

Ive been looking at this issue in the code and I think this should be possible to fix by adding some sort of indices file which contains the indices, offsets and hashes. If I'm not mistaken, we will have to add the indices file itself to the file as well (inception) but this could probably be calculated beforehand?

Not sure how much time this would cut off the load times of Spring Boot apps. Every millisecond counts I guess.

Also, I assume we would have to keep backwards compatibility in mind when loading the jar, so that previously packaged jars still work ofcourse?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: performance Issues related to general performance type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants