Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: spring-projects/spring-security
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: spring-projects/spring-security
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: gh-16886
Choose a head ref
  • 4 commits
  • 224 files changed
  • 1 contributor

Commits on Jul 2, 2025

  1. Deprecate createMvcMatchers 

    Issue gh-16631
    @jzheaux
    jzheaux committed Jul 2, 2025
    Configuration menu
    Copy the full SHA
    b7ebf41 View commit details
    Browse the repository at this point in the history

  2. Polish equals and hashcode

    @jzheaux
    jzheaux committed Jul 2, 2025
    Configuration menu
    Copy the full SHA
    75f30d1 View commit details
    Browse the repository at this point in the history

  3. Prgress

    @jzheaux
    jzheaux committed Jul 2, 2025
    Configuration menu
    Copy the full SHA
    ef50ff2 View commit details
    Browse the repository at this point in the history

  4. Standardize Mocked Request Paths 

    Historically, Spring Security tests have set the servlet path
to indicate the path of a MockHttpServletRequest. This was needed
for AntPath and MvcRequestMatcher to correctly match the
specified request path.

This can leave MockHttpServletRequest in an inconsistent state
since requestURI is null while servletPath has a value.

For example, PathPatternRequestMatcher does not use the servlet path.
For tests to continue working both before and after the migration
from AntPath/MvcRequestMatcher to PathPatternRequestMatcher, the
mock requests should have a consistent representation of path
in getRequestURI and getServletPath.

This commit updates classes to use TestMockHttpServletRequests,
which ensures that the given path is applied to the servletPath and
requestURI, while also overriding with contextPath, servletPath,
and pathInfo when necessary.
    @jzheaux
    jzheaux committed Jul 2, 2025
    Configuration menu
    Copy the full SHA
    531c5ca View commit details
    Browse the repository at this point in the history
Loading