Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

关于grpc subscriber中的一个拼写错误 #27

Closed
yiippee opened this issue Nov 11, 2020 · 1 comment · Fixed by #45
Closed

关于grpc subscriber中的一个拼写错误 #27

yiippee opened this issue Nov 11, 2020 · 1 comment · Fixed by #45

Comments

@yiippee
Copy link

yiippee commented Nov 11, 2020

go-micro 1.18好像找不到了,但在你们的stack-rpc中还有。
请教一个问题啊,在 https://github.com/stack-labs/stack-rpc/blob/master/server/grpc/subscriber.go: 261

		for i := 0; i < len(sb.handlers); i++ {
			if rerr := <-results; **err** != nil {   // 这里的 err 是不是应该是 rerr 啊?要不订阅返回错误会被忽略了,不会重发。
				errors = append(errors, rerr.Error())
			}
		}
@printfcoder
Copy link
Member

@yiippee 是的,可以PR吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants