Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miner should panic if mining_key is not set #5473

Closed
obycode opened this issue Nov 18, 2024 · 2 comments · Fixed by #5498
Closed

Miner should panic if mining_key is not set #5473

obycode opened this issue Nov 18, 2024 · 2 comments · Fixed by #5498
Assignees
@ASuciuX
Labels
good first issue Appropriate for a new open source contribution. locked

Comments

@obycode
Copy link
Contributor

obycode commented Nov 18, 2024

Since the mining_key is required now that Nakamoto is active, MinerConfigFile::into_config_default should panic if it is not set. Otherwise, someone trying to mine could spend Bitcoin but then fail to mine blocks.
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Nov 18, 2024
@obycode obycode added the good first issue Appropriate for a new open source contribution. label Nov 18, 2024
@obycode
Copy link
Contributor Author

obycode commented Nov 18, 2024

Alternative to panicking, it could instead default to using the miner's seed as the mining key if it is not defined.

@ASuciuX ASuciuX self-assigned this Nov 19, 2024
This was referenced Nov 21, 2024
Closed
Merged
@ASuciuX ASuciuX closed this as completed Jan 27, 2025
@github-project-automation github-project-automation bot moved this from Status: 🆕 New to Status: ✅ Done in Stacks Core Eng Jan 27, 2025
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ASuciuX ASuciuX

Labels
good first issue Appropriate for a new open source contribution. locked
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If miner has no mining key set, automatically set it to node seed stacks-network/stacks-core
3 participants
@obycode @blockstack-devops @ASuciuX