Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Signer] Miner activity should only count specific bad block proposals #5749

Closed
jferrant opened this issue Jan 27, 2025 · 1 comment · Fixed by #5755
Closed

[Signer] Miner activity should only count specific bad block proposals #5749

jferrant opened this issue Jan 27, 2025 · 1 comment · Fixed by #5755
Assignees
Milestone

Comments

@jferrant
Copy link
Contributor

jferrant commented Jan 27, 2025

Currently signers will count any block proposal that passes initial checks towards miner activity. However, a signer should be smarter about what counts as activity as a miner could simply having an outdated view or it could actually be a bad tenure where that miner will either not catch up/is misconfigured/is malicious.

Add a database table that tracks consensus hash to a last active timestamp. This last active timestamp should be used in the is_timed_out fn check in chainstate.rs. If a tenure has not had a single approved block, check this last active timestamp against the block_proposal_timeout.

This timestamp should get updated if a block proposal tries to reorg the last block of the prior tenure but only within a certain number of seconds of the tenure start and only block proposals at the tenure change boundary really matter. I.e. these block proposals will also have to pass tenure change transaction validity checks. It may need to accomodate locally vs globally accepetd block reorg attempts as well.

@jferrant jferrant self-assigned this Jan 27, 2025
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Jan 27, 2025
@jferrant jferrant added this to the 3.1.0.0.5 milestone Jan 27, 2025
@jferrant jferrant changed the title [Signer] Miner activity should be only count specific bad block proposals [Signer] Miner activity should only count specific bad block proposals Jan 27, 2025
@jferrant jferrant moved this from Status: 🆕 New to Status: In Review in Stacks Core Eng Jan 30, 2025
@aldur aldur modified the milestones: 3.1.0.0.5, 3.1.0.0.6 Feb 4, 2025
@aldur aldur closed this as completed Feb 6, 2025
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Feb 6, 2025
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Status: ✅ Done
3 participants