Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap Course #173

Closed
Archdoog opened this issue Aug 4, 2024 · 1 comment
Closed

Snap Course #173

Archdoog opened this issue Aug 4, 2024 · 1 comment
Assignees
Labels
android bug Something isn't working core Related to the Rust core iOS

Comments

@Archdoog
Copy link
Collaborator

Archdoog commented Aug 4, 2024

We currently pass the device's course through to the UI. On android this causes an issue where the map view drifts to north whenever you're stopped for more than second? or so. To avoid this, we should always provide the snapped (or snapped within range) course. We could also offer configuration since the ideal behavior may differ between platform. E.g.:

enum SnapCourseTo {
    /// Course provide by core is always the direction of travel from the route. As long as the user is "snapped", if they go
    /// off course, we should unsnap entirely and then the user puck should just show the device's location + course.
    case snapped

    /// This is the device's course within an allowable range off. Basically we report the actual device course up to the +- the amplitude.
    case deviceWithinRangeOfSnapped(amplitude)

    /// As it is now, we just report what the device tells us for course. Allowing the UI to drift to north.
    case device
}
@Archdoog Archdoog added bug Something isn't working android iOS labels Aug 4, 2024
@ianthetechie ianthetechie self-assigned this Aug 13, 2024
@ianthetechie ianthetechie added the core Related to the Rust core label Aug 13, 2024
@Archdoog Archdoog self-assigned this Sep 14, 2024
@Archdoog
Copy link
Collaborator Author

This is done as of 0.11.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working core Related to the Rust core iOS
Projects
Status: Done
Development

No branches or pull requests

2 participants