-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework versions for models #82
Comments
I agree with your solution. |
I had an idea for one approach we can use if we need to include a model under {
"name": "some_model",
"model_implementations": {
"stan": {
"model_code": "models/stan/some_model.stan",
"min_version": 3.1
}
},
"other_stuff": "..."
} So we specify a minimal version of Stan that is needed to run this model implementation It might be preferrable to usually use {
"name": "some_model",
"model_implementations": {
"stan3": {
"model_code": "models/stan/some_model.stan"
}
},
"other_stuff": "..."
} but I could see the first approach being an useful option to have in some cases |
I agree that it is useful to have this feature. I just add for clarification, there is not yet |
Good clarification. Having one set of Stan models feels feasable to me. |
From what I understand the
stan3
modelling language might not be exactly the same as with current stan.pymc3
andpymc4
also have different modeling languages.Currently the plan is to have each
stan
model undermodels/stan
and pymc models undermodels/pymc
. How could we support having models in the posterior database for bothstan2
andstan3
or forpymc3
andpymc4
?One approach would be reserve
models/stan
forstan2
andmodels/pymc
forpymc3
and add models of newer versions undermodels/stan3
andmodels/pymc4
. This approach doesn't feel satisfactory for me, but at the moment I don't have any better ideas either.The text was updated successfully, but these errors were encountered: