-
Notifications
You must be signed in to change notification settings - Fork 17
Please consider the following #97
Comments
I could try working on these. I'll work on the two linter tasks first and then the task to get the current project name afterwards. |
Hi @lannonbr , if you can start with # 3 (the eslint-node-plugin). We should get a 👍 from @stefanjudis before # 2. |
Okay, so you want any of the eslint-plugin-node rules changed or just have them use the defaults? |
I implemented the first task in PR #99. |
@lannonbr Just the defaults for eslint-plugin-node , Be sure to add the engines object to the package. See here: stefanjudis/credits@38b1c7f |
@Hypercubed Okay, I can work on that in about 4 hours. I'll notify you if I have any issues. |
Well yeah. 2. and 3. are fine for me... What's the benefit of 2? I don't mind, just out of curiosity. :) |
@stefanjudis Re # 2 , mostly personal preference, but for FWIW:
|
Well yeah. Personal preference. ¯_(ツ)_/¯ |
Doesn't bother me that much. At least you have semicolons. Edit: and I need spell-check. |
Haha, yes! 🎉 |
A few suggestions I think we can consider:
The text was updated successfully, but these errors were encountered: