Skip to content
This repository has been archived by the owner on Apr 15, 2022. It is now read-only.

Please consider the following #97

Open
1 of 3 tasks
Hypercubed opened this issue Oct 15, 2016 · 11 comments
Open
1 of 3 tasks

Please consider the following #97

Hypercubed opened this issue Oct 15, 2016 · 11 comments

Comments

@Hypercubed
Copy link
Collaborator

Hypercubed commented Oct 15, 2016

A few suggestions I think we can consider:

  • Get the current project name from the name attribute in the package.json instead of the folder name.
  • Migrate from eslint with custom rules to xo.
  • Use eslint-plugin-node to ensure post node v4 features are not accidentally added.
@lannonbr
Copy link
Contributor

I could try working on these. I'll work on the two linter tasks first and then the task to get the current project name afterwards.

@Hypercubed
Copy link
Collaborator Author

Hi @lannonbr , if you can start with # 3 (the eslint-node-plugin). We should get a 👍 from @stefanjudis before # 2.

@lannonbr
Copy link
Contributor

Okay, so you want any of the eslint-plugin-node rules changed or just have them use the defaults?

@lannonbr
Copy link
Contributor

I implemented the first task in PR #99.

@Hypercubed
Copy link
Collaborator Author

Hypercubed commented Oct 18, 2016

@lannonbr Just the defaults for eslint-plugin-node , Be sure to add the engines object to the package. See here: stefanjudis/credits@38b1c7f

@lannonbr
Copy link
Contributor

@Hypercubed Okay, I can work on that in about 4 hours. I'll notify you if I have any issues.

@stefanjudis
Copy link
Owner

Well yeah. 2. and 3. are fine for me...

What's the benefit of 2? I don't mind, just out of curiosity. :)

@Hypercubed
Copy link
Collaborator Author

@stefanjudis Re # 2 , mostly personal preference, but for FWIW:

  1. I find the current eslint rules awkward. For a project with multiple contributors may be better to select a common set.
  2. It seems some reasonable eslint rules are not enabled, for example, checks for unused variables.
  3. I really like the xo atom plugin.
  4. xo, as opposed to standard or semi-standard, allows overriding the default rules.

@stefanjudis
Copy link
Owner

I find the current eslint rules awkward. For a project with multiple contributors may be better to select a common set

Well yeah. Personal preference. ¯_(ツ)_/¯
When you mean the spacing, if it bothers you so much, go ahead. 😄

@Hypercubed
Copy link
Collaborator Author

Hypercubed commented Oct 19, 2016

Doesn't bother me that much. At least you have semicolons.

Edit: and I need spell-check.

@stefanjudis
Copy link
Owner

At least you have semicolens.

Haha, yes! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants