Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are the actual risks of vulnerabilities caused by deviations? #1912

Closed
Subway2023 opened this issue Jan 6, 2025 · 2 comments
Closed

Comments

@Subway2023
Copy link

Component

sp1-zkvm

Describe the feature you would like

What are the actual risks of vulnerabilities caused by deviations (such as execution results being inconsistent with expectations, shown in bug)?
What impact could this have on zk-rollups or blockchain?

Additional context

No response

@themighty1
Copy link

The risks are a complete loss of soundness. But to exploit it, the attacker has to use unsafe {} iiuc.
To mitigate, we can pin the dependencies to prevent supply-chain attacks + audit the guest program code.

@nhtyy
Copy link
Collaborator

nhtyy commented Jan 23, 2025

Thank you @themighty1 I agree those are good practices to ensure security! Closing for now but feel free to follow up with any questions or if you think its should be reopened.

@nhtyy nhtyy closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants