Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be aware of bad brushes #6

Open
sunkper opened this issue Feb 16, 2020 · 1 comment
Open

Be aware of bad brushes #6

sunkper opened this issue Feb 16, 2020 · 1 comment

Comments

@sunkper
Copy link
Owner

sunkper commented Feb 16, 2020

CursedMesh

While building map with Trenchbroom, be aware of bad brushes like this. This is too complex for its size, liable to errors like it happened while testing master version of Qodot. What I wrote on Qodot Discord:

Godot puts out error messages regarding quick_hull (https://pastebin.com/eAAYXRmz) when loading the result geometry. Turns out these little things I lazily put are to blame. This does not happen with current stable version.

(Yeah, I probably shouldn't put this kind of geometry when dealing with quake map format to begin with, but I guess this is worth reporting. Anyway good reminder to replace those things with simpler and cleaner shapes.)

@sunkper sunkper added bug Something isn't working lesson optimization and removed bug Something isn't working labels Feb 16, 2020
@sunkper
Copy link
Owner Author

sunkper commented Mar 17, 2020

From Qodot Discord, Shifty's comment about quick_hull errors:

re. the quick_hull error, that one's a non-issue at runtime so you don't need to worry there
the editor invokes quick_hull to create the wireframes it displays for collision geo, and it seems to get tripped up by corner / edge cases much easier than the actual collision code
it does means brushes aren't clickable in the editor until quick_hull reruns though (ex. switching to a different scene and back), so i'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant