Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If first element of build path is an empty string, builds fail with unhelpful error messages #142

Open
a-morphous opened this issue Jun 22, 2024 · 0 comments
Milestone

Comments

@a-morphous
Copy link

Hello, this is a problem I just debugged and solved for myself for a few hours, and thought it'd be useful to share with others:

I was trying to use the buildtool (latest master, downloaded and put into the Packages folder), but all builds were failing with '1 error' and no more specific issues. It turns out that because the version had been blank (I hadn't known you had to generate a new version), and my desired build paths began with $VERSION/, the paths being produced began with /. This overwrote the build directory when using Path.Combine here:

string buildPath = Path.Combine(BuildSettings.basicSettings.baseBuildFolder, resolvedPath);
and caused all paths to try to be written from /, which fails because Unity doesn't have access to that directory.

I think this is a case where the tool should warn or error out before even reaching the build; if a piece of the path would produce an empty string, I think it's worth noting since those issues can cause paths to behave unexpectedly like I saw.

@robinnorth robinnorth added this to the Backlog milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants