Skip to content

Commit 17678da

Browse files
committed
Fix Win64 va_arg.
--- Merging r127328 into '.': U test/CodeGen/X86/win64_vararg.ll U lib/Target/X86/X86ISelLowering.cpp git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_29@128044 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent fcce259 commit 17678da

File tree

2 files changed

+38
-3
lines changed

2 files changed

+38
-3
lines changed

lib/Target/X86/X86ISelLowering.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1750,8 +1750,8 @@ X86TargetLowering::LowerFormalArguments(SDValue Chain,
17501750
// If the function takes variable number of arguments, make a frame index for
17511751
// the start of the first vararg value... for expansion of llvm.va_start.
17521752
if (isVarArg) {
1753-
if (!IsWin64 && (Is64Bit || (CallConv != CallingConv::X86_FastCall &&
1754-
CallConv != CallingConv::X86_ThisCall))) {
1753+
if (Is64Bit || (CallConv != CallingConv::X86_FastCall &&
1754+
CallConv != CallingConv::X86_ThisCall)) {
17551755
FuncInfo->setVarArgsFrameIndex(MFI->CreateFixedObject(1, StackSize,true));
17561756
}
17571757
if (Is64Bit) {
@@ -1803,7 +1803,9 @@ X86TargetLowering::LowerFormalArguments(SDValue Chain,
18031803
int HomeOffset = TFI.getOffsetOfLocalArea() + 8;
18041804
FuncInfo->setRegSaveFrameIndex(
18051805
MFI->CreateFixedObject(1, NumIntRegs * 8 + HomeOffset, false));
1806-
FuncInfo->setVarArgsFrameIndex(FuncInfo->getRegSaveFrameIndex());
1806+
// Fixup to set vararg frame on shadow area (4 x i64).
1807+
if (NumIntRegs < 4)
1808+
FuncInfo->setVarArgsFrameIndex(FuncInfo->getRegSaveFrameIndex());
18071809
} else {
18081810
// For X86-64, if there are vararg parameters that are passed via
18091811
// registers, then we must store them to their spots on the stack so they

test/CodeGen/X86/win64_vararg.ll

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,36 @@ entry:
1818
}
1919

2020
declare void @llvm.va_start(i8*) nounwind
21+
22+
; CHECK: f5:
23+
; CHECK: pushq
24+
; CHECK: leaq 56(%rsp),
25+
define i8* @f5(i64 %a0, i64 %a1, i64 %a2, i64 %a3, i64 %a4, ...) nounwind {
26+
entry:
27+
%ap = alloca i8*, align 8
28+
%ap1 = bitcast i8** %ap to i8*
29+
call void @llvm.va_start(i8* %ap1)
30+
ret i8* %ap1
31+
}
32+
33+
; CHECK: f4:
34+
; CHECK: pushq
35+
; CHECK: leaq 48(%rsp),
36+
define i8* @f4(i64 %a0, i64 %a1, i64 %a2, i64 %a3, ...) nounwind {
37+
entry:
38+
%ap = alloca i8*, align 8
39+
%ap1 = bitcast i8** %ap to i8*
40+
call void @llvm.va_start(i8* %ap1)
41+
ret i8* %ap1
42+
}
43+
44+
; CHECK: f3:
45+
; CHECK: pushq
46+
; CHECK: leaq 40(%rsp),
47+
define i8* @f3(i64 %a0, i64 %a1, i64 %a2, ...) nounwind {
48+
entry:
49+
%ap = alloca i8*, align 8
50+
%ap1 = bitcast i8** %ap to i8*
51+
call void @llvm.va_start(i8* %ap1)
52+
ret i8* %ap1
53+
}

0 commit comments

Comments
 (0)