feat(elastigroup/aws): added max_scale_down_percentage in kubernetes_integrations (spotinst#463)

feat(elastigroup/aws): added `max_scale_down_percentage` in `kubernetes_integrations`

Author: chandra1-n

CHANGELOG.md

@@ -1,5 +1,9 @@
 ## Unreleased
 
+## 1.136.0 (September 07, 2023)
+ENHANCEMENTS:
+* resource/spotinst_elastigroup_aws: Added `max_scale_down_percentage` field in `kubernetes_integrations` object
+
 ## 1.135.0 (September, 06 2023)
 BUG FIXES:
 * resource/spotinst_ocean_aks_np: Fix for ignoring the unnecessary changes shown during terraform plan for the attributes inside `filters` object

docs/resources/elastigroup_aws.md

@@ -891,6 +891,7 @@ integration_docker_swarm {
         * `num_of_units` - (Optional, Default: `0`) How many units to allocate for headroom unit.
     * `autoscale_down` - (Optional) Setting for scale down actions.
         * `evaluation_periods` - (Optional, Default: `5`) How many evaluation periods should accumulate before a scale down action takes place.
+        * `max_scale_down_percentage` - (Optional) Represents the maximum percent to scale-down. Number between 1-100.
     * `autoscale_labels` - (Optional) A key/value mapping of tags to assign to the resource.
 
 Usage:
@@ -918,6 +919,7 @@ Usage:
     
     autoscale_down {
       evaluation_periods = 300
+      max_scale_down_percentage = 50
     }
     
     autoscale_labels {

spotinst/elastigroup_aws_integrations/fields_spotinst_elastigroup_aws_integrations_kubernetes.go

@@ -89,6 +89,11 @@ func SetupKubernetes(fieldsMap map[commons.FieldName]*commons.GenericField) {
 									Type:     schema.TypeInt,
 									Optional: true,
 								},
+
+								string(MaxScaleDownPercentage): {
+									Type:     schema.TypeFloat,
+									Optional: true,
+								},
 							},
 						},
 					},
@@ -205,7 +210,7 @@ func expandAWSGroupKubernetesIntegration(data interface{}) (*aws.KubernetesInteg
 	}
 
 	if v, ok := m[string(AutoscaleDown)]; ok {
-		down, err := expandAWSGroupAutoScaleDown(v, false)
+		down, err := expandAWSGroupAutoScaleDown(v, true)
 		if err != nil {
 			return nil, err
 		}

spotinst/resource_spotinst_elastigroup_aws_test.go

@@ -3708,6 +3708,7 @@ func TestAccSpotinstElastigroupAWS_IntegrationKubernetes(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_headroom.0.memory_per_unit", "512"),
 					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_headroom.0.num_of_units", "2"),
 					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_down.0.evaluation_periods", "300"),
+					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_down.0.max_scale_down_percentage", "70"),
 					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_labels.0.key", "test.key.k8s"),
 					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_labels.0.value", "test.value.k8s"),
 				),
@@ -3733,6 +3734,7 @@ func TestAccSpotinstElastigroupAWS_IntegrationKubernetes(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_headroom.0.memory_per_unit", "1024"),
 					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_headroom.0.num_of_units", "1"),
 					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_down.0.evaluation_periods", "150"),
+					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_down.0.max_scale_down_percentage", "30"),
 					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_labels.0.key", "test.key.k8s.update"),
 					resource.TestCheckResourceAttr(resourceName, "integration_kubernetes.0.autoscale_labels.0.value", "test.value.k8s.update"),
 				),
@@ -3771,6 +3773,7 @@ const testIntegrationKubernetesGroupConfig_Create = `
 
     autoscale_down {
       evaluation_periods = 300
+	  max_scale_down_percentage = 70
     }
 
     autoscale_labels {
@@ -3800,6 +3803,7 @@ const testIntegrationKubernetesGroupConfig_Update = `
 
     autoscale_down {
       evaluation_periods = 150
+	  max_scale_down_percentage = 30
     }
 
     autoscale_labels {