Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uart_tx and uart_rx seem to have wrong direction in the Verilog framework file for the ECPIX5-Board #254

Open
at91rm9200 opened this issue Aug 19, 2023 · 1 comment

Comments

@at91rm9200
Copy link

at91rm9200 commented Aug 19, 2023

Hello Sylvain,

it looks as if the directions of the signals uart_tx and uart_rx are swapped in the Verilog framework file for the ECPIX5 board.

module top(
  // basic
  output [11:0] leds,
`ifdef UART
  // uart
  output  uart_rx, // ?
  input   uart_tx, // ?
`endif

Regards, Bernd.

Edit:
this is confusing. According to the schematics of the board, uart_rx is indeed an output and uart_tx is an input.

But then, I don't understand the following declarations in the Verilog framework file:

M_main __main(
  .reset         (RST_q[0]),
  .in_run        (run_main),
  .out_leds      (__main_leds),
`ifdef UART
  .out_uart_tx  (uart_tx), // shouldn't this be then input?
  .in_uart_rx   (uart_rx), // shouldn't this be then output?
`endif
@sylefeb
Copy link
Owner

sylefeb commented Aug 24, 2023

Hi Bernd, thanks for looking into this! I'm away from the board right now so cannot test, but I seem to remember being confused about this when doing the profile. (Might be a confusion with which side we look at, unsure what the convention is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants