Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/security-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7.3
Choose a base ref
...
head repository: symfony/security-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7.4
Choose a head ref
  • 15 commits
  • 20 files changed
  • 7 contributors

Commits on Jun 2, 2025

  1. Allow Symfony ^8.0

    nicolas-grekas committed Jun 2, 2025
    Configuration menu
    Copy the full SHA
    aad9d48 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2025

  1. Merge branch '7.3' into 7.4

    * 7.3:
      [HttpClient] Suggest amphp/http-client v5 by default
      [WebProfilerBundle] Fix typos in routing config deprecation messages
      cs tweak
      [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass
      Revert "bug #60564 [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass (cquintana92)"
      [Security] Keep roles when serializing tokens
      [JsonPath] Always use brackets notation with `JsonPath::key()`
    nicolas-grekas committed Jun 5, 2025
    Configuration menu
    Copy the full SHA
    47b3412 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2025

  1. Merge branch '7.3' into 7.4

    * 7.3:
      Revert "minor #60377 [HttpFoundation] Emit PHP warning when `Response::sendHeaders()` is called while output has already been sent (ivo95v)"
      [Validator] Add missing HasNamedArguments to some constraints
    nicolas-grekas committed Jun 23, 2025
    Configuration menu
    Copy the full SHA
    df9ce9a View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2025

  1. Configuration menu
    Copy the full SHA
    f90d78b View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2025

  1. Various CS fixes

    nicolas-grekas committed Jul 8, 2025
    Configuration menu
    Copy the full SHA
    c374c96 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2025

  1. optimize in_array calls

    gharlan authored and nicolas-grekas committed Jul 15, 2025
    Configuration menu
    Copy the full SHA
    986bf58 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2025

  1. Merge branch '7.3' into 7.4

    * 7.3:
      [ObjectMapper] Fix test using LazyObjectInterface
      [Security] Fix added $token argument to UserCheckerInterface::checkPostAuth()
      minor #61192 [ObjectMapper] add missing legacy group (xabbuh)
      bugfix(#61139): Only generate an outputDir if none is set.
    nicolas-grekas committed Jul 22, 2025
    Configuration menu
    Copy the full SHA
    378f5bf View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2025

  1. Merge branch '7.3' into 7.4

    * 7.3:
      Add missing use statement for @param
    alexandre-daubois committed Jul 23, 2025
    Configuration menu
    Copy the full SHA
    61c0d41 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2025

  1. run tests using PHPUnit 11.5

    xabbuh committed Jul 31, 2025
    Configuration menu
    Copy the full SHA
    bfa94f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2025

  1. Configuration menu
    Copy the full SHA
    72792ef View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2025

  1. run tests with PHPUnit 12.3

    xabbuh committed Aug 12, 2025
    Configuration menu
    Copy the full SHA
    03a133b View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2025

  1. Merge branch '7.3' into 7.4

    * 7.3:
      [VarExporter] Fix serializing classes with __serialize() returning unprefixed private properties
      Remove direct access to internal properties cross-components
    nicolas-grekas committed Aug 18, 2025
    Configuration menu
    Copy the full SHA
    499eb11 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2025

  1. Configuration menu
    Copy the full SHA
    201a65b View commit details
    Browse the repository at this point in the history
  2. feature #61057 [Security] Improve performance of `RoleHierarchy::buil…

    …dRoleMap` method (simonjamain-gp, simonjamain)
    
    This PR was squashed before being merged into the 7.4 branch.
    
    Discussion
    ----------
    
    [Security] Improve performance of `RoleHierarchy::buildRoleMap` method
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 7.4
    | Bug fix?      | no
    | New feature?  | no (perf)
    | Deprecations? | no
    | Issues        | Fix #57322
    | License       | MIT
    
    use of an optimized role ustacking function
    
    ### What it does and why it's needed
    
    _Note : Better in-detail explanation in there : https://github.com/symfony/symfony/issues/57322_
    Uses the way faster `array_pop()` function to build the role map instead of `array shift`
    
    ### If it modifies existing behavior, include a before/after comparison
    
    At first, it would look like this function swap could change slightly the ordering of the array produced by the `RoleHierarchy::buildRoleMap` method and it does it in a way. I find that it does not change the behaviour of our app.
    
    I would not expect most other apps too break because I don't find many reasons to rely on the ordering of roles in hierarchies. Furthermore, `buildRoleMap` is a protected method serving the public `getReachableRoleNames` which does not imply a particular ordering (rightfully so IMHO).
    
    ### Testing
    
    As it does not change or introduce any behavious per say, this performance increase rely on old tests passing again.
    If I am not mistaken, the current `testGetReachableRoleNames()` still passes even tho it asserts a specific ordering. I still changed the assertion so it does not convey any false premises.
    
    Commits
    -------
    
    508b62fd788 [Security] Improve performance of `RoleHierarchy::buildRoleMap` method
    fabpot committed Aug 23, 2025
    Configuration menu
    Copy the full SHA
    7777353 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b5ee9f6 View commit details
    Browse the repository at this point in the history
Loading