Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 32bit Windows #175

Open
nuwa358n opened this issue Sep 6, 2021 · 7 comments
Open

Add support for 32bit Windows #175

nuwa358n opened this issue Sep 6, 2021 · 7 comments

Comments

@nuwa358n
Copy link

nuwa358n commented Sep 6, 2021

this software not supported for 32bit Windows, how can install for windows 32bit

@szTheory
Copy link
Owner

szTheory commented Sep 6, 2021

Thanks for reaching out. I see that electron-builder supports 32 bit architecture, but it's not enabled by default and I just wasn't building with that --x64 --ia32 option enabled. I added the flag here, will ship it for the next release.

https://www.electron.build/configuration/nsis.html#32-bit-64-bit

@PolpOnline
Copy link
Contributor

PolpOnline commented Sep 6, 2021

For some reason, this doesn't build on my machine (and apparently neither in GitHub's CI), it says that configuration.win has an unknown property 'arch'.
You can see the CI log here

@szTheory
Copy link
Owner

szTheory commented Sep 6, 2021

Sorry I messed up the package.json on master. arch should have been nested under the target property, per the docs here https://www.electron.build/cli.html. I've pushed an update to master here, hopefully that fixes it.

@PolpOnline
Copy link
Contributor

I think that it worked, but I see that there isn't a 64-bit portable executable in the artifacts (just a setup and a portable version, both 32 bit according to the file GNU utility).
However, this isn't a real issue because I think that this app wouldn't really benefit the 64-bit, and if one would need a 64-bit version they would just use the setup.

@szTheory
Copy link
Owner

szTheory commented Sep 6, 2021

Any way you can get the 64 bit version working for portable as well? Maybe if you add it to the arch options similar to how it is for the nsi it will just work

@PolpOnline
Copy link
Contributor

@szTheory I'm testing it, if it succeeds I'll submit a PR with the change

@PolpOnline
Copy link
Contributor

PolpOnline commented Sep 6, 2021

@szTheory I tried adding the arch entry for the portable build (in a test branch, so I can build with GitHub's machines) but the artifacts results are the same...

@szTheory szTheory changed the title not supported for 32bit Windows Add support for 32bit Windows Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants