forked from swiftlang/swift
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request swiftlang#34688 from etcwilde/ewilde/disallow-pass…
…ing-actor-state-inout [Concurrency] Ban passing actor state via inout Resolves: rdar://70635479
- Loading branch information
Showing
3 changed files
with
231 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| // RUN: %target-typecheck-verify-swift -enable-experimental-concurrency | ||
| // REQUIRES: concurrency | ||
|
|
||
| // Verify that we don't allow actor-isolated state to be passed via inout | ||
| // Check: | ||
| // - can't pass it into a normal async function | ||
| // - can't pass it into a first-class async function as a value | ||
| // - can't pass it into another actor method | ||
| // - can't pass it into a curried/partially applied function | ||
| // - can't pass it inout to a function that doesn't directly touch it | ||
| // - can't pass it into a function that was passed into the calling method | ||
| // - can't call async mutating function on actor isolated state | ||
|
|
||
| struct Point { | ||
| var x: Int | ||
| var y: Int | ||
|
|
||
| mutating func setComponents(x: inout Int, y: inout Int) async { | ||
| defer { (x, y) = (self.x, self.y) } | ||
| (self.x, self.y) = (x, y) | ||
| } | ||
| } | ||
|
|
||
| actor class TestActor { | ||
| var position = Point(x: 0, y: 0) | ||
| var nextPosition = Point(x: 0, y: 1) | ||
| var value1: Int = 0 | ||
| var value2: Int = 1 | ||
| } | ||
|
|
||
| func modifyAsynchronously(_ foo: inout Int) async { foo += 1 } | ||
| let modifyAsyncValue = modifyAsynchronously | ||
|
|
||
| // external function call | ||
| extension TestActor { | ||
|
|
||
| // Can't pass actor-isolated primitive into a function | ||
| func inoutAsyncFunctionCall() async { | ||
| // expected-error@+1{{actor-isolated property 'value1' cannot be passed 'inout' to 'async' function call}} | ||
| await modifyAsynchronously(&value1) | ||
| } | ||
|
|
||
| func inoutAsyncClosureCall() async { | ||
| // expected-error@+1{{actor-isolated property 'value1' cannot be passed 'inout' to 'async' function call}} | ||
| await { (_ foo: inout Int) async in foo += 1 }(&value1) | ||
| } | ||
|
|
||
| // Can't pass actor-isolated primitive into first-class function value | ||
| func inoutAsyncValueCall() async { | ||
| // expected-error@+1{{actor-isolated property 'value1' cannot be passed 'inout' to 'async' function call}} | ||
| await modifyAsyncValue(&value1) | ||
| } | ||
|
|
||
| // Can't pass property of actor-isolated state inout to async function | ||
| func inoutPropertyStateValueCall() async { | ||
| // expected-error@+1{{actor-isolated property 'position' cannot be passed 'inout' to 'async' function call}} | ||
| await modifyAsynchronously(&position.x) | ||
| } | ||
| } | ||
|
|
||
| // internal method call | ||
| extension TestActor { | ||
| func modifyByValue(_ other: inout Int) async { | ||
| other += value1 | ||
| } | ||
|
|
||
| func passStateIntoMethod() async { | ||
| // expected-error@+1{{actor-isolated property 'value1' cannot be passed 'inout' to 'async' function call}} | ||
| await modifyByValue(&value1) | ||
| } | ||
| } | ||
|
|
||
| // external class method call | ||
| class NonAsyncClass { | ||
| func modifyOtherAsync(_ other : inout Int) async { | ||
| // ... | ||
| } | ||
|
|
||
| func modifyOtherNotAsync(_ other: inout Int) { | ||
| // ... | ||
| } | ||
| } | ||
|
|
||
| // Calling external class/struct async function | ||
| extension TestActor { | ||
| // Can't pass state into async method of another class | ||
|
|
||
| func passStateIntoDifferentClassMethod() async { | ||
| let other = NonAsyncClass() | ||
| let otherCurry = other.modifyOtherAsync | ||
| // expected-error@+1{{actor-isolated property 'value2' cannot be passed 'inout' to 'async' function call}} | ||
| await other.modifyOtherAsync(&value2) | ||
| // expected-error@+1{{actor-isolated property 'value1' cannot be passed 'inout' to 'async' function call}} | ||
| await otherCurry(&value1) | ||
| other.modifyOtherNotAsync(&value2) // This is okay since it's not async! | ||
|
|
||
| } | ||
|
|
||
| func callMutatingFunctionOnStruct() async { | ||
| // expected-error@+3:20{{cannot call mutating async function 'setComponents(x:y:)' on actor-isolated property 'position'}} | ||
| // expected-error@+2:51{{actor-isolated property 'nextPosition' cannot be passed 'inout' to 'async' function call}} | ||
| // expected-error@+1:71{{actor-isolated property 'nextPosition' cannot be passed 'inout' to 'async' function call}} | ||
| await position.setComponents(x: &nextPosition.x, y: &nextPosition.y) | ||
|
|
||
| // expected-error@+3:20{{cannot call mutating async function 'setComponents(x:y:)' on actor-isolated property 'position'}} | ||
| // expected-error@+2:38{{actor-isolated property 'value1' cannot be passed 'inout' to 'async' function call}} | ||
| // expected-error@+1:50{{actor-isolated property 'value2' cannot be passed 'inout' to 'async' function call}} | ||
| await position.setComponents(x: &value1, y: &value2) | ||
| } | ||
| } | ||
|
|
||
| // Check implicit async testing | ||
| actor class DifferentActor { | ||
| func modify(_ state: inout Int) {} | ||
| } | ||
|
|
||
| extension TestActor { | ||
| func modify(_ state: inout Int) {} | ||
|
|
||
| // Actor state passed inout to implicitly async function on an actor of the | ||
| // same type | ||
| func modifiedByOtherTestActor(_ other: TestActor) async { | ||
| //expected-error@+1{{actor-isolated property 'value2' cannot be passed 'inout' to implicitly 'async' function call}} | ||
| await other.modify(&value2) | ||
| } | ||
|
|
||
| // Actor state passed inout to an implicitly async function on an actor of a | ||
| // different type | ||
| func modifiedByOther(_ other: DifferentActor) async { | ||
| //expected-error@+1{{actor-isolated property 'value2' cannot be passed 'inout' to implicitly 'async' function call}} | ||
| await other.modify(&value2) | ||
| } | ||
| } |