Skip to content

Commit 56a9af7

Browse files
Document the new default value for 'replication_sync_timeout' (#3507)
1 parent 10a9fe2 commit 56a9af7

7 files changed

+19
-14
lines changed

doc/reference/configuration/cfg_replication.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,11 @@
346346
| Environment variable: TT_REPLICATION_SYNC_TIMEOUT
347347
| Dynamic: **yes**
348348
349+
.. NOTE::
350+
351+
The default ``replication_sync_timeout`` value is going to be changed in future versions from ``300`` to ``0``.
352+
You can learn the reasoning behind this decision from the :ref:`Default value for replication_sync_timeout <compat-option-replication-timeout>` topic, which also describes how to try the new behavior in the current version.
353+
349354
.. _cfg_replication-replication_timeout:
350355

351356
.. confval:: replication_timeout

doc/reference/reference_lua/compat/box_cfg_replication_sync_timeout.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Default value for replication_sync_timeout
44
==========================================
55

6-
Having a non-zero ``replication_sync_timeout`` gives a user the false assumption that the ``box.cfg{replication = ...}`` call returns only when the configured node is synced with all the other nodes.
6+
Having a non-zero :ref:`replication_sync_timeout <cfg_replication-replication_sync_timeout>` gives a user the false assumption that the ``box.cfg{replication = ...}`` call returns only when the configured node is synced with all the other nodes.
77
This is mostly true for the big ``replication_sync_timeout`` values, but it is not 100% guaranteed.
88
In other words, a user still has to check if the node is synced, or the sync just timed out.
99
Besides, while ``replication_sync_timeout`` is ticking, you cannot reconfigure ``box`` with another ``box.cfg`` call, which hardens reconfiguration.
@@ -13,7 +13,7 @@ It is decided to set the ``replication_sync_timeout`` to zero by default.
1313
Old and new behavior
1414
--------------------
1515

16-
The ``compat`` module allows you chose between
16+
The ``compat`` module allows you to choose between
1717

1818
* the old behavior: ``box.cfg.replication_sync_timeout`` is 300 seconds by default
1919

@@ -59,8 +59,8 @@ Known compatibility issues
5959

6060
At this point, no incompatible modules are known.
6161

62-
Detecting issues in you codebase
63-
--------------------------------
62+
Detecting issues in your codebase
63+
---------------------------------
6464

6565
We expect issues with a user assuming that the node is not in the orphan state (``box.info.status ~= "orphan"``) after the ``box.cfg{replication=...}`` call returns.
6666
This is not true with the new behaviour. To simulate the old behavior, one may add a ``box.ctl.wait_rw()`` call after the ``box.cfg{}`` call.

doc/reference/reference_lua/compat/fiber_channel_close_mode.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ Known compatibility issues
9999

100100
At this point, no incompatible modules are known.
101101

102-
Detecting issues in you codebase
103-
--------------------------------
102+
Detecting issues in your codebase
103+
---------------------------------
104104

105105
The new behavior is mostly backward compatible.
106106
The only known problem that can appear is when the code relies on channel being entirely closed after ``ch:close()`` and ``ch:get()`` returning ``nil``.

doc/reference/reference_lua/compat/fiber_slice_default.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ Known compatibility issues
2323

2424
At this point, no incompatible modules are known.
2525

26-
Detecting issues in you codebase
27-
--------------------------------
26+
Detecting issues in your codebase
27+
---------------------------------
2828

2929
If you see a warning like this in the log:
3030

doc/reference/reference_lua/compat/json_escape_forward_slash.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ Known compatibility issues
3939

4040
At this point, no incompatible modules are known.
4141

42-
Detecting issues in you codebase
43-
--------------------------------
42+
Detecting issues in your codebase
43+
---------------------------------
4444

4545
Both encoding styles are correct from the JSON standard standpoint, but if your module relies on encodings results bytewise, it may break with this change.
4646
Be cautious if you do the following:

doc/reference/reference_lua/compat/sql_seq_scan_default.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ Known compatibility issues
8888

8989
At this point, no incompatible modules are known.
9090

91-
Detecting issues in you codebase
92-
--------------------------------
91+
Detecting issues in your codebase
92+
---------------------------------
9393

9494
We expect most SELECTs that do not use indexes to fail after the ``sql_seq_scan`` session setting is set to false.
9595
The best way to avoid this is to refactor the query to use indexes.

doc/reference/reference_lua/compat/yaml_pretty_multiline.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ Known compatibility issues
4747

4848
At this point, no incompatible modules are known.
4949

50-
Detecting issues in you codebase
51-
--------------------------------
50+
Detecting issues in your codebase
51+
---------------------------------
5252

5353
Both encoding styles are correct from the YAML standard standpoint, but if your module relies on encodings results bytewise, it may break with this change.
5454
Be cautious if you do the following:

0 commit comments

Comments
 (0)