Skip to content

Variable self._is_first_run in ListRedisScheduleSource doesn't work #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lryan599 opened this issue May 8, 2025 · 1 comment
Open
Assignees

Comments

@lryan599
Copy link

lryan599 commented May 8, 2025

if not self._skip_past_schedules:

According to the comments, this condition should be

if not self._skip_past_schedules and self._is_first_run:

Otherwise, the variable self._is_first_run is not used at all.

@s3rius
Copy link
Member

s3rius commented May 10, 2025

Yeah. I should fix this comment. Because as it turned out, you should fetch previous schedules every time. Because otherwise you loose them completely.

@s3rius s3rius self-assigned this May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants