Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh CI? #187

Open
5 of 9 tasks
BradyBonnette opened this issue Jan 26, 2023 · 1 comment
Open
5 of 9 tasks

Refresh CI? #187

BradyBonnette opened this issue Jan 26, 2023 · 1 comment

Comments

@BradyBonnette
Copy link
Contributor

BradyBonnette commented Jan 26, 2023

After some discussion, we have noted that the plrust CI may need a little love. It's been a while since updates have been performed on it, and now that a bunch of stuff has changed both internally in the plrust project and with some of it's dependencies like PGX, it might be time to refresh it a little.

Some ideas to start off:

  • Reintroduce ability to use sccache for aarch64 (broken via using plrustc)
  • Use sccache for the x86_64 tasks (and generate the cache keys appropriately, including the pg version in the filename)
  • Maybe break the trusted vs. untrusted tests into separate jobs (might see a speedup here, or maybe not!)
  • Try to figure out how to re-enable the MacOS builds (they were disabled originally because things kept breaking)
  • Enable the use of RUSTFLAGS=-Dwarnings to fail the build if there are any warnings present
  • Possibly gate the build with some quick-running tasks, like rustfmt and audit?
  • Maybe some general formatting/restructuring of ci.yml so that it's easier to find in both the yaml file and the resulting output in the Github Actions pages
  • Make use of pre-built docker images that we can use with Github Actions container registry: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry
  • ???
@workingjubilee
Copy link
Contributor

Maybe break the trusted vs. untrusted tests into separate jobs (might see a speedup here, or maybe not!)

Probably would cut CI time in half, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants