Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "path" from labels to keep cardinality low #1

Closed
emmenko opened this issue Aug 9, 2018 · 5 comments
Closed

Remove "path" from labels to keep cardinality low #1

emmenko opened this issue Aug 9, 2018 · 5 comments

Comments

@emmenko
Copy link
Contributor

emmenko commented Aug 9, 2018

No description provided.

@tdeekens
Copy link
Owner

Thanks for the issue. Raising cardinality problems is also good 😁.

I‘ve added some tests to ensure that the default normalizer does at least something:

  1. Should we add more specs?
  2. What do you see missing?

Reference to the spec: https://github.com/tdeekens/promster/blob/master/packages/metrics/modules/normalizers/path/path.spec.js

@tdeekens
Copy link
Owner

As a side note: you can always pass a custom normalizer during configuration to be more strict. However, let me know if we definitely don’t normalize enough.

@tdeekens
Copy link
Owner

I elaborated on the expectations towards the default normalisation. It meets by expectations towards a sensible default for well-formed urls. It's also what most other express/hapi exporters settled up doing.

@emmenko
Copy link
Contributor Author

emmenko commented Aug 13, 2018

I got a bit lost but ok, as long as you are aware of the cardinality problem and that the library handles this I'm fine 😇

@emmenko emmenko closed this as completed Aug 13, 2018
@tdeekens
Copy link
Owner

It tries to offer a reasonably sane default. It's mostly aligned with the 3-4 other exporters which do the same. Given that more have this we can either drop the url or try to be even more strict. I've looked into how and can't really think of a way for now.

Thanks again for raising it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants