-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Added label "field_name" is not included in initial labelset #867
Comments
Thanks a lot for reporting and the proposed fix. Upon first glimpse it looks good. I will set aside some time to review. Do you want to open a PR? |
Not 100% sure about the snapshot in my PR, specifically the error count value, but I think the test itself is doing the right thing. Let me know if there's anything I can do to fix/tidy the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Errors thrown in GraphQL execute phase are not handled:
To Reproduce
Steps to reproduce the behavior:
And directive which throws an error in execute phase won't be handled / counted.
Expected behavior
Expect
graphql_errors_total
to incrementAdditional context
Attempted to write a test for the issue here, not sure if the solution is correct https://github.com/tdeekens/promster/compare/main...earnubs:errors-in-execution-phase?expand=1
The text was updated successfully, but these errors were encountered: