From 7fc793ec083c8fdaa5b230ef3b13183cf3d30f88 Mon Sep 17 00:00:00 2001 From: Sachin N Date: Mon, 8 Aug 2016 22:43:48 +0530 Subject: [PATCH] Update contributing.md --- contributing.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/contributing.md b/contributing.md index b1657c6..c170c50 100644 --- a/contributing.md +++ b/contributing.md @@ -16,9 +16,12 @@ First, ensure that you have the latest [Node.js](http://nodejs.org/) and [npm](h ## Submitting pull requests Pull requests are very welcome. Note that if you are going to propose drastic changes, be sure to open an issue for discussion first, to make sure that your PR will be accepted before you spend effort coding it. -1. Create a new branch, please don't work in your `master` branch directly. +1. Javascript changes of lightgallery plugins should be made in repective github repositoy. +2. SCSS and CSS changes should be made in lightgallery.js repository. Ex: If you want to submit a PR for lightgallery.js thumbnails plugin javacsript changes should be submitted in [lg-thumbnails.js](https://github.com/sachinchoolur/lg-thumbnail.js) repository and SCSS and CSS changes should be submitted in [lightgallery.js](https://github.com/sachinchoolur/lightgallery.js) repository. +2. Create a new branch, please don't work in your `master` branch directly. 1. Add failing tests for the change you want to make. Run `npm run build` to see the tests fail. 1. Fix stuff. 1. Run `npm run build` to see if the tests pass. Repeat steps 2-4 until done. 1. Update the documentation to reflect any changes. +2. Please do not include minified files with the pull request as i will do it myself. 1. Push to your fork and submit a pull request.