Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode color updates #361

Open
c0deswitch opened this issue Mar 18, 2024 · 3 comments
Open

Dark mode color updates #361

c0deswitch opened this issue Mar 18, 2024 · 3 comments

Comments

@c0deswitch
Copy link
Collaborator

Proposing the following edits to improve readability:

Dark Mode

Make background color darker to increase contrast between text and bg
.primaryBg { background: #191919; }

Change nav bar color
.secondaryBg { background: #2E2E2E; }

@shushugah
Copy link
Member

I believe this is done with #360. But if you have more/further light/dark theme improvements to suggest, let's discuss them here. In general, I noticed with black on white, it's important to have more bold typefaces to make the light colors easier to read on a dark background.

@c0deswitch
Copy link
Collaborator Author

thanks, it's looking better! i had indicated for the primary Bg to be the darker gray so it got implemented in reverse but it's still better than the light gray it was before.

for best legibility the contrast between the background color and text color should be as high as possible. you'll notice when you switch between light and dark mode on websites or apps like Slack, the text weight typically doesn't change, just the colors do. i do agree that we can make other typographic improvements like adjusting font weights across both - light and dark mode.

@shushugah
Copy link
Member

shushugah commented Mar 27, 2024

Pending tasks

  • Switch grey and grey2 color variables
  • Add make a:hover black in light-theme mode
  • Make a light-theme related css for mobile nav links (see image below)
  • Make event-cards in /events h3 tags instead of h2. See Create /events tab #350 for further event improvements
Screenshot 2024-03-28 at 18 04 43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants