Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: lint - improve detection of required keys #3429

Open
bgoncalv opened this issue Dec 16, 2024 · 0 comments
Open

RFE: lint - improve detection of required keys #3429

bgoncalv opened this issue Dec 16, 2024 · 0 comments

Comments

@bgoncalv
Copy link

for example: https://gitlab.com/redhat/centos-stream/tests/kernel/kernel-tests/-/blob/443974f498ddbec25af53e2c8f066d2901c5bd3a/tracepoints/operational/main.fmf#L21

it set

 - type: library
    pattern:
      - /cki_lib/libcki.sh

tmt lint would not fail:

$ tmt lint tracepoints
/tracepoints/operational
pass C000 fmf node passes schema validation
pass C001 summary key is set and is reasonably long
pass T001 correct keys are used
pass T002 test script is defined
pass T003 directory path is absolute
pass T004 test path '/home/bgoncalv/repos/cki/kernel-tests/tracepoints/operational' does exist
skip T005 legacy relevancy not detected
skip T006 legacy 'coverage' field not detected
skip T007 not a manual test
skip T008 not a manual test
pass T009 all library/file requirements specify type

Lint checks on all
pass G001 no duplicate ids detected

but tmt discover would fail with:

$ tmt run discover
/var/tmp/tmt/run-005

/default/plan
    discover
        how: fmf
        directory: /home/bgoncalv/repos/cki/kernel-tests

plan failed

The exception was caused by 1 earlier exceptions

Cause number 1:

    Need 'url' or 'path' to fetch a beakerlib library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant