Error in .view()

[steven-murray]

When calling .view it raises an error, since plt is not defined. I think instead of if not plt:... it should be try: plt.xxx ... except: xxx

[telegraphic]

Not sure what that code is all about :/

I just fixed this and made a whole bunch of other changes: https://github.com/telegraphic/pygdsm

The new pygdsm repo:

• works in Py3,
• uses astropy's download_file to serve the HDF5 files (it will download them on first run).
• added the LWA low frequency sky model
• made base classes for the GSM and Observer, so codebase is smaller
• Is now a unique name, so can push to pypi (pyGSM was already taken)
• doesn't have large files hiding in its git history after ill-fated git-LFS

[steven-murray]

Oh nice!

I'll move my deps over to that library. What's the "d" stand for?

[telegraphic]

'd' for diffuse. Name is up for debate though, its a bit alphabet salad-y. Hows about glosmod? Any suggestions?

Ps: I'm considering submitting to JOSS, would you be interested in being listed as an author?

[steven-murray]

Ah, diffuse makes sense. I actually like pygdsm -- I think sticking close to gsm or pygsm is a good idea for discoverability.

I've submitted a few things to JOSS before, so certainly willing to help on that front. Not sure I've done enough on this repo to count as an author -- but if you've got any loose ends that need tying up I'm happy to help out and be on the paper!

BTW, there's a few straggling references to pyGSM on the new repo's README. Might be helpful to do a search+replace.