Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove or expose code in common/ #1615

Open
joneff opened this issue Jun 12, 2020 · 1 comment
Open

Refactor: remove or expose code in common/ #1615

joneff opened this issue Jun 12, 2020 · 1 comment
Assignees
@joneff @inikolova @JoomFX @silviyaboteva
Labels
Enhancement New feature of an existing functionality or an improvement of an existing functionality. Internal

Comments

@joneff
Copy link
Contributor

joneff commented Jun 12, 2020

Moving forward with v5, we need to either remove or expose the code from the common folder as modules.

Parts of it, like the appearance mixins will need to be removed. Other parts, like the icons, typography and utilities will need to be exposed as top level modules.
@joneff joneff added Enhancement New feature of an existing functionality or an improvement of an existing functionality. Internal labels Jun 12, 2020
@joneff joneff added this to the 2020.3 milestone Jun 12, 2020
@silviyaboteva silviyaboteva mentioned this issue Jun 29, 2020
Merged
@joneff joneff self-assigned this Aug 6, 2020
@joneff joneff mentioned this issue Aug 6, 2020
Merged
@joneff joneff modified the milestones: 2020.3, 2021.1 Aug 25, 2020
@joneff joneff modified the milestones: 2021.1, 2021.2 Dec 17, 2020
@joneff joneff modified the milestones: 2021.2, 2021.3 May 4, 2021
@joneff joneff modified the milestones: 2021.3, 2022.1 Sep 2, 2021
@joneff joneff modified the milestones: 2022.1, 2022.2 Jan 19, 2022
@silviyaboteva
Copy link
Contributor

What's already done:

  • Removed appearance mixins
  • Exposed icons as separate module
  • Exposed typography as separate module
  • Exposed utilities as separate module

@joneff, what else have to be done here?

@hadjieva hadjieva removed this from the 2022.2 milestone Feb 8, 2022
@joneff joneff mentioned this issue May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joneff joneff

@inikolova inikolova

@JoomFX JoomFX

@silviyaboteva silviyaboteva

Labels
Enhancement New feature of an existing functionality or an improvement of an existing functionality. Internal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joneff @inikolova @JoomFX @hadjieva @silviyaboteva