Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component options for dateinput #2797

Closed
2 tasks done
joneff opened this issue Sep 16, 2021 · 3 comments
Closed
2 tasks done

Component options for dateinput #2797

joneff opened this issue Sep 16, 2021 · 3 comments
Assignees
Labels
Breaking Change Item which is introducing a breaking change. C:Dateinput Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Milestone

Comments

@joneff
Copy link
Contributor

joneff commented Sep 16, 2021

Dependencies

Component options

enum DateinputSize { small, medium, large };
enum DateinputRounded { small, medium, large, pill };
enum DateinputFillMode { solid, flat, outline };

class Dateinput {
   size: (null | DateinputSize) = DateinputSize.medium;
   rounded: (null | DateinputRounded) = DateinputRounded.medium;
   fillMode: (null | DateinputFillMode) = DateinputFillMode.solid;
}

Rendering

  • Rendering
<!-- default rendering -->
<span class="k-dateinput k-input k-input-md k-rounded-md k-input-solid">
    <input type="text" class="k-input-inner" value="..." placeholder="..." />
    <span class="k-input-spinner k-spin-button">
        <button class="k-spinner-increase k-button k-icon-button k-button-solid k-button-solid-base">
            <span class="k-button-icon k-icon k-i-arrow-n"></span>
        </button>
        <button class="k-spinner-decrease k-button k-icon-button k-button-solid k-button-solid-base">
            <span class="k-button-icon k-icon k-i-arrow-s"></span>
        </button>
    </span>
</span>

<!-- canonical rendering -->
<span class="
    k-dateinput
    k-input
    k-input-{size}
    k-rounded-{rounded}
    k-input-{fillMode}

    {valid && 'k-valid'}
    {invalid && 'k-invalid'}
    {loading && 'k-loading'}
    {required && 'k-required'}
    {disabled && 'k-disabled'}
">
    {showInputIcon && inputIconName !== '' && <span class="k-input-icon k-icon k-i-{inputIconName}"></span>}
    {inputPrefix && <span class="k-input-prefix">...</span>}
    <input type={type} class="k-input-inner" value={value} placeholder={placeholder} disabled={disabled} />
    {inputPrefix && <span class="k-input-suffix">...</span>}
    {showValidationIcon && valid && <span class="k-input-validation-icon k-icon k-i-check"></span>}
    {showValidationIcon && invalid && <span class="k-input-validation-icon k-icon k-i-warning"></span>}
    {showLoadingIcon && loading && <span class="k-input-loading-icon k-icon k-i-loading"></span>}
    {showClearValue && text !== '' && <span class="k-clear-value"><span class="k-icon k-i-x"></span></span>}
    {showSpinButton &&
        <span class="k-input-spinner k-spin-button">
            <button class="k-spinner-increase k-button k-icon-button k-button-solid k-button-solid-base">
                <span class="k-button-icon k-icon k-i-arrow-n"></span>
            </button>
            <button class="k-spinner-decrease k-button k-icon-button k-button-solid k-button-solid-base">
                <span class="k-button-icon k-icon k-i-arrow-s"></span>
            </button>
        </span>
    }
</span>

Documentation

  • Variables
@joneff joneff added Enhancement New feature of an existing functionality or an improvement of an existing functionality. C:Dateinput labels Sep 16, 2021
@joneff joneff added this to the 2022.1 milestone Sep 16, 2021
@joneff joneff added the Breaking Change Item which is introducing a breaking change. label Sep 16, 2021
@tapopov
Copy link
Contributor

tapopov commented Dec 14, 2021

Loading indicator is a bit wonky and roundness is ignored (see example)

@joneff
Copy link
Contributor Author

joneff commented Jan 19, 2022

Loading indicator is a bit wonky and roundness is ignored (see example)

Albeit a bit late, I updated the markup (and will do so for all such components).

@joneff
Copy link
Contributor Author

joneff commented Jan 19, 2022

Shipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Item which is introducing a breaking change. C:Dateinput Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Projects
None yet
Development

No branches or pull requests

3 participants