Changing network/subnet properties does not update deployment

[ocervell]

Steps to reproduce:

module "vpc-network" {
  source       = "github.com/terraform-google-modules/terraform-google-network"
  project_id   = "${module.vpc-host.project_id}"
  network_name = "tf-training-network"

  subnets = [
    {
      subnet_name   = "gke-prod"
      subnet_ip     = "10.0.0.0/17"
      subnet_region = "us-east1"
    },
    {
      subnet_name   = "gke-dev"
      subnet_ip     = "10.1.0.0/17"
      subnet_region = "us-east1"
    }
  ]

  secondary_ranges = {
    gke-prod = []
    gke-dev = []
  }
}

Add subnet_flow_logs = true to one of the subnets and get no new changes when running terraform apply. Same for other additional flags passed to any subnet.

Update: This is the same when adding shared_vpc_host = true (meaning we can't currently convert a vpc to a shared vpc)

[andreyk-code]

Unable to reproduce. Try using a string for shared_vpc_host and a boolean for subnet_flow_logs.

$ terraform apply
google_compute_network.network: Refreshing state... (ID: tf-training-network)
google_compute_network.network: Refreshing state... (ID: test-vpc-module)
google_compute_subnetwork.subnetwork[0]: Refreshing state... (ID: us-east1/gke-prod)
google_compute_subnetwork.subnetwork[1]: Refreshing state... (ID: us-east1/gke-dev)
google_compute_subnetwork.subnetwork[1]: Refreshing state... (ID: us-west1/subnet-02)
google_compute_subnetwork.subnetwork[0]: Refreshing state... (ID: us-west1/subnet-01)

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  + module.test-vpc-module.google_compute_shared_vpc_host_project.shared_vpc_host
      id:               <computed>
      project:          "ref-gke-shared-svc"

  ~ module.vpc-network.google_compute_subnetwork.subnetwork[0]
      enable_flow_logs: "false" => "true"

Plan: 1 to add, 1 to change, 0 to destroy.

[morgante]

@andreyk-code Maybe we should standardize on using string variables? (ie "true" for subnet_flow_logs)

[morgante]

#9 to track that standardization.

Closing this as @andreyk-code and I cannot reproduce. @ocervell reopen if you have reproduction.