Skip to content

Commit 0b383f2

Browse files
committed
ci(actions): oops, actually check types πŸ€¦πŸ»β€β™‚οΈ
1 parent aa88056 commit 0b383f2

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

β€Ž.github/workflows/build.yml

+8-4
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,16 @@ on:
1313

1414
jobs:
1515
build:
16-
name: Build + Test + Release / Node ${{ matrix.node }}
16+
name: Build + Test + Release / Node ${{ matrix.node }} / playwright@${{ matrix.playwright }}
1717
runs-on: ubuntu-latest
1818
strategy:
1919
matrix:
2020
node: ['12', '14', '16']
21-
playwright: ['1.12.0', 'latest']
21+
# TODO: technically we still support down to 1.12 but `locator.waitFor`
22+
# was introduced in 1.16 so anything earlier blows up type-checking.
23+
# This minimum will be bumped in the next breaking release that will be
24+
# entirely built around the `Locator` APIs, so update this then.
25+
playwright: ['1.16.0', 'latest']
2226

2327
steps:
2428
- name: Checkout
@@ -50,14 +54,14 @@ jobs:
5054
- name: Check types
5155
run: npm run test:types
5256

53-
- name: Check types, run lint + tests
57+
- name: Run lint + tests
5458
if: ${{ matrix.playwright == 'latest' }}
5559
run: |
5660
npm why playwright
5761
npm why @playwright/test
5862
npm run test
5963
60-
- name: Check types, run lint + tests
64+
- name: Run lint + tests
6165
if: ${{ matrix.playwright != 'latest' }}
6266
run: |
6367
npm why playwright

0 commit comments

Comments
Β (0)