Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quire IIIF QA #815

Open
9 of 18 tasks
Erin-Cecele opened this issue Aug 9, 2023 · 8 comments
Open
9 of 18 tasks

Quire IIIF QA #815

Erin-Cecele opened this issue Aug 9, 2023 · 8 comments
Assignees
Labels
iiif An issue related to IIIF processing, canvas-panel, or sequence-panel status:backlog Issue is a lower priority but needs to eventually be addressed

Comments

@Erin-Cecele
Copy link
Collaborator

Erin-Cecele commented Aug 9, 2023

Before proceeding, make sure there isn’t an existing issue for this bug.

  • I have searched the existing issues and determined this is a new bug.

Expected Behavior

This story is to capture all issues related to the core functioning of basci IIIF zooming images.

We've pushed some assets and content to the QA-iiif branch of the quire-starter-iiif repo as well to help with testing.

  • print-image files are transformed to jpg but are being called based on their source format
  • Only .jpgs are working as zooming images
  • .jp2 images that are set to zoom cause a previewing/build error
  • Zooming images below a certain threshold size don't display in the lightbox
  • IIIF manifests outputting with extra slash
  • High-res images are included in _site even when not needed
  • Add +/- bottons to lightbox / canvas panel to control zooming
  • The print-image.jpg files need to be a larger size for print-ready PDF
  • Enable tiling PNGs
  • IIIF images are ghosting duplicates with any interaction in the modal
  • External IIIF manifests are not rendering
  • External IIIF images should only need printImage not also src
  • Paths to printImage file are incomplete in PDF and EPUB output
  • External printImage should work in the table of contents grid
  • Use of info.json as src is no longer functional or needed
  • Refactor out use of camelCase for external IIIF in figures.yaml?
  • Use the first canvasId by default if one is not supplied along with the manifestId?

Actual Behavior

N/A

Steps to Reproduce

N/A

Version Numbers

N/A

Web Browser

No response

Relevant Terminal/Shell Output

No response

Supporting Information

No response

@Erin-Cecele Erin-Cecele added status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. iiif An issue related to IIIF processing, canvas-panel, or sequence-panel labels Aug 9, 2023
@Erin-Cecele Erin-Cecele self-assigned this Aug 9, 2023
@Erin-Cecele
Copy link
Collaborator Author

Updates:

@Erin-Cecele Erin-Cecele added status:backlog Issue is a lower priority but needs to eventually be addressed and removed status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. labels Aug 22, 2023
@cbutcosk
Copy link
Collaborator

@Erin-Cecele I'm not sure if this is already included in your list above, but fullscreen buttons do not appear to work on any browser at the moment. Or maybe they're being factored out?

At any rate if you start any new quire pub and click a figure, the "fullscreen" button in the upper left does nothing and produces an error about classList in the console. Happens on Safari 16.6 and Chrome 116. Tested today with quire-1.0-rc.14

@Erin-Cecele
Copy link
Collaborator Author

@cbutcosk, thank you for reporting this. I just fired up a new project and noticed that neither the images in the "Introduction" or Figure 1 and Figure 2 in "I. American Photographs" go fullscreen when you click the button in the upper left.

However, in "Cat. 1" Figure 1.1 and Figure 1.2 do open in fullscreen when the button is clicked. Also, both main catalogue entry images also open just fine. Can you confirm if the entry page images are going fullscreen for you? I wonder if the issue is somehow tied to layout type?

@Erin-Cecele
Copy link
Collaborator Author

Oh and here's my work environment information:

[Project]
quire-cli 1.0.0-rc.10
quire-11ty 1.0.0-rc.14
starter https://github.com/thegetty/[email protected]
[System]
quire-cli 1.0.0-rc.10
node v18.16.0
npm 9.5.1
os Darwin 21.6.0

And I tested with Chrome 114 and Firefox 117 - same results.

@cbutcosk
Copy link
Collaborator

@Erin-Cecele Yes confirming the entry page seems to work where the essay full screen buttons do not. I suspect your developers also need to add a Shadow DOM polyfill for Safari < 16.5 (mobile and desktop), which in this issue breaks in a slightly different way from the Chromium-based browsers.

@Erin-Cecele Erin-Cecele added status:in progress Issue is under development status:backlog Issue is a lower priority but needs to eventually be addressed and removed status:backlog Issue is a lower priority but needs to eventually be addressed status:in progress Issue is under development labels Sep 13, 2023
@Erin-Cecele Erin-Cecele removed their assignment Sep 13, 2023
@Erin-Cecele Erin-Cecele added status:in progress Issue is under development and removed status:backlog Issue is a lower priority but needs to eventually be addressed labels Sep 13, 2023
@Erin-Cecele Erin-Cecele self-assigned this Sep 13, 2023
@Erin-Cecele
Copy link
Collaborator Author

Hi @cbutcosk, please note I have opened a separate issue to address the fullscreen bug you spotted. See: #849

@Erin-Cecele
Copy link
Collaborator Author

Status update as of 10/11

  • High-res images are included in _site even when not needed - SELECTED FOR DEVELOPMENT
  • Add +/- bottons to lightbox / canvas panel to control zooming - BACKLOG
  • Enable tiling PNGs - BLOCKED
  • IIIF images are ghosting duplicates with any interaction in the modal - BLOCKED
  • External IIIF images should only need printImage not also src - BACKLOG
  • Paths to printImage file are incomplete in PDF and EPUB output - BACKLOG
  • External printImage should work in the table of contents grid - BACKLOG
  • Use of info.json as src is no longer functional or needed - BACKLOG
  • Refactor out use of camelCase for external IIIF in figures.yaml? - BACKLOG
  • Use the first canvasId by default if one is not supplied along with the manifestId? - BACKLOG

@Erin-Cecele Erin-Cecele added status:backlog Issue is a lower priority but needs to eventually be addressed and removed status:in progress Issue is under development labels Oct 11, 2023
@Erin-Cecele
Copy link
Collaborator Author

Only update as of 11/30 is "High-res images are included in _site even when not needed" is backlogged and not selected for development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iiif An issue related to IIIF processing, canvas-panel, or sequence-panel status:backlog Issue is a lower priority but needs to eventually be addressed
Projects
None yet
Development

No branches or pull requests

2 participants