do not alias ctrl.data, which can be replaced (fixes lichess-org#6127, closes lichess-org#6254)

Author: niklasf

ui/round/src/socket.ts

@@ -68,13 +68,11 @@ export function make(send: SocketSend, ctrl: RoundController): RoundSocket {
     });
   };
 
-  const d = ctrl.data;
-
   const handlers: Handlers = {
     takebackOffers(o) {
       ctrl.setLoading(false);
-      d.player.proposingTakeback = o[d.player.color];
-      const fromOp = d.opponent.proposingTakeback = o[d.opponent.color];
+      ctrl.data.player.proposingTakeback = o[ctrl.data.player.color];
+      const fromOp = ctrl.data.opponent.proposingTakeback = o[ctrl.data.opponent.color];
       if (fromOp) notify(ctrl.noarg('yourOpponentProposesATakeback'));
       ctrl.redraw();
     },
@@ -90,34 +88,34 @@ export function make(send: SocketSend, ctrl: RoundController): RoundSocket {
     },
     cclock(o) {
       if (ctrl.corresClock) {
-        d.correspondence.white = o.white;
-        d.correspondence.black = o.black;
+        ctrl.data.correspondence.white = o.white;
+        ctrl.data.correspondence.black = o.black;
         ctrl.corresClock.update(o.white, o.black);
         ctrl.redraw();
       }
     },
     crowd(o) {
-      game.setOnGame(d, 'white', o['white']);
-      game.setOnGame(d, 'black', o['black']);
+      game.setOnGame(ctrl.data, 'white', o['white']);
+      game.setOnGame(ctrl.data, 'black', o['black']);
       ctrl.redraw();
     },
     endData(o: ApiEnd) {
       ctrl.endWithData(o);
     },
     rematchOffer(by: Color) {
-      d.player.offeringRematch = by === d.player.color;
-      if (d.opponent.offeringRematch = by === d.opponent.color)
+      ctrl.data.player.offeringRematch = by === ctrl.data.player.color;
+      if (ctrl.data.opponent.offeringRematch = by === ctrl.data.opponent.color)
         notify(ctrl.noarg('yourOpponentWantsToPlayANewGameWithYou'));
       ctrl.redraw();
     },
     rematchTaken(nextId: string) {
-      d.game.rematch = nextId;
-      if (!d.player.spectator) ctrl.setLoading(true);
+      ctrl.data.game.rematch = nextId;
+      if (!ctrl.data.player.spectator) ctrl.setLoading(true);
       else ctrl.redraw();
     },
     drawOffer(by) {
-      d.player.offeringDraw = by === d.player.color;
-      const fromOp = d.opponent.offeringDraw = by === d.opponent.color;
+      ctrl.data.player.offeringDraw = by === ctrl.data.player.color;
+      const fromOp = ctrl.data.opponent.offeringDraw = by === ctrl.data.opponent.color;
       if (fromOp) notify(ctrl.noarg('yourOpponentOffersADraw'));
       ctrl.redraw();
     },
@@ -127,16 +125,16 @@ export function make(send: SocketSend, ctrl: RoundController): RoundSocket {
     gone: ctrl.setGone,
     goneIn: ctrl.setGone,
     checkCount(e) {
-      d.player.checks = d.player.color == 'white' ? e.white : e.black;
-      d.opponent.checks = d.opponent.color == 'white' ? e.white : e.black;
+      ctrl.data.player.checks = ctrl.data.player.color == 'white' ? e.white : e.black;
+      ctrl.data.opponent.checks = ctrl.data.opponent.color == 'white' ? e.white : e.black;
       ctrl.redraw();
     },
     simulPlayerMove(gameId: string) {
       if (
         ctrl.opts.userId &&
-        d.simul &&
-        ctrl.opts.userId == d.simul.hostId &&
-        gameId !== d.game.id &&
+        ctrl.data.simul &&
+        ctrl.opts.userId == ctrl.data.simul.hostId &&
+        gameId !== ctrl.data.game.id &&
         ctrl.moveOn.get() &&
         !isPlayerTurn(ctrl.data)) {
         ctrl.setRedirecting();
@@ -160,7 +158,7 @@ export function make(send: SocketSend, ctrl: RoundController): RoundSocket {
     send,
     handlers,
     moreTime: throttle(300, () => send('moretime')),
-    outoftime: backoff(500, 1.1, () => send('flag', d.game.player)),
+    outoftime: backoff(500, 1.1, () => send('flag', ctrl.data.game.player)),
     berserk: throttle(200, () => send('berserk', null, { ackable: true })),
     sendLoading(typ: string, data?: any) {
       ctrl.setLoading(true);