Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID and stacking behavior for darts, javelins #334

Open
apgove opened this issue Apr 25, 2021 · 6 comments
Open

ID and stacking behavior for darts, javelins #334

apgove opened this issue Apr 25, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@apgove
Copy link

apgove commented Apr 25, 2021

Enhancement request: found javelins, darts, and incendiary darts should start out identified as +0.

Experienced players know that all stackables are uncursed, and thus a found javelin is a safe mid-game upgrade from the starting dagger. But this feels like illicit knowledge and generally contradicts Brogue's ethos of all cards on the table.

As a corollary, it would then be reasonable to combine like items found separately into a single stack occupying a single inventory slot.

@pender
Copy link
Contributor

pender commented Apr 25, 2021

Or maybe they should be able to spawn with an innate + or - enchant!

@blossom7
Copy link

Hah, that is such a characteristically cheeky reply. I like it.

+1 to the idea of stacking incendiary darts and javelins, though.

@pender
Copy link
Contributor

pender commented Apr 25, 2021

I would argue against free stacking of different sets of throwables, for what it's worth.

@withinwheels
Copy link
Contributor

I also like the idea of keeping the door open to spawning blessed (cursed?) throwables. Maybe blessed ones have an improved chance of runic slaying?

@apgove
Copy link
Author

apgove commented Apr 26, 2021

Right, allowing throwables to be generated with enchantments would obviously negate the original issue report, and I agree that would make for a more interesting change. Changing only the starting ID behavior, I expect, would be a simpler, stopgap change not requiring a major version bump, and perhaps make it more obvious that enchantment levels had been added when the starting ID change is reverted.

I've never actually tried meleeing with incendiary darts, does that generate infinite combustion? +15 incendiary darts of multiplicity might be fun!

@tmewett
Copy link
Owner

tmewett commented Sep 3, 2021

👍 for being identified by default, if needed we can make a separate issue to discuss merging stacks once done

@tmewett tmewett added the enhancement New feature or request label Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants