Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About tonbo unit testing #87

Open
caicancai opened this issue Aug 17, 2024 · 4 comments
Open

About tonbo unit testing #87

caicancai opened this issue Aug 17, 2024 · 4 comments
Assignees

Comments

@caicancai
Copy link
Contributor

caicancai commented Aug 17, 2024

Feature Request

tonbo currently seems to lack some unit tests. I'm not sure if it's too early to bring this up, but this should be something to consider.

  1. Which path should unit tests be placed in?
  2. Unit test standards
@ethe
Copy link
Member

ethe commented Aug 17, 2024

  1. I think all unit test cases should be placed in the module they test, while all integration test cases should be placed in tests/, unless a single module ends up with too many tests.
  2. This is quite a large topic. What are your thoughts? I think we could look at more stable Rust databases, such as sled or redb, for guidance.

@caicancai
Copy link
Contributor Author

caicancai commented Aug 18, 2024

  1. I think all unit test cases should be placed in the module they test, while all integration test cases should be placed in tests/, unless a single module ends up with too many tests.
  2. This is quite a large topic. What are your thoughts? I think we could look at more stable Rust databases, such as sled or redb, for guidance.

I'm not very clear about Rust's unit testing standards, I think I will study redb's unit testing and then come up with my approach.

Let's go

@KKould KKould added the S - Small Fixing small bugs, adjusting UI styles, optimizing existing functions. label Sep 3, 2024
@caicancai
Copy link
Contributor Author

@ethe I am very sorry that this work has not been carried out for so long. I am adapting to the new job recently and I expect to be able to start this work next month. I am very sorry.

@ethe
Copy link
Member

ethe commented Nov 21, 2024

It's ok, I will wait for you ❤️

@ethe ethe removed S - Small Fixing small bugs, adjusting UI styles, optimizing existing functions. test cases labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants