Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public dependency on once_cell #575

Open
CosmicHorrorDev opened this issue Mar 11, 2025 · 1 comment
Open

Public dependency on once_cell #575

CosmicHorrorDev opened this issue Mar 11, 2025 · 1 comment

Comments

@CosmicHorrorDev
Copy link
Contributor

CosmicHorrorDev commented Mar 11, 2025

Now that there are things like OnceLock (since 1.70.0) and LazyLock(since 1.80.0) in the standard library it'd be nice to migrate off of once_cell. The one current issue with this is that it's a breaking change for this library due to syntect::parsing::SCOPE_REPO being a part of the public API while it's a once_cell::sync::Lazy. It'd be nice to change this in the next breaking release if possible (and I'd be willing to open a PR to handle it)

@keith-hall
Copy link
Collaborator

I wonder if anyone ever actually uses syntect::parsing::SCOPE_REPO, most likely I expect it wouldn't be a big deal to change it and release a new major version as it would be trivial to upgrade 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants