Skip to content
This repository was archived by the owner on Jul 13, 2022. It is now read-only.

Commit 62a5e7f

Browse files
author
Shahak Yosef
committed
Merged PR 183663: Add renderingStarted event
Add loadingScreenHidden event Mirror one [external PR](microsoft#365 (comment)). Update powerbi-models version.
1 parent 1264c1f commit 62a5e7f

File tree

4 files changed

+26
-7
lines changed

4 files changed

+26
-7
lines changed

dist/powerbi.js

+23-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/powerbi.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/report.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export interface IReportNode {
6464
*/
6565
export class Report extends Embed implements IReportNode, IFilterable {
6666
/** @hidden */
67-
static allowedEvents = ["filtersApplied", "pageChanged", "commandTriggered", "swipeStart", "swipeEnd", "bookmarkApplied", "dataHyperlinkClicked", "visualRendered", "visualClicked", "selectionChanged"];
67+
static allowedEvents = ["filtersApplied", "pageChanged", "commandTriggered", "swipeStart", "swipeEnd", "bookmarkApplied", "dataHyperlinkClicked", "visualRendered", "visualClicked", "selectionChanged", "renderingStarted"];
6868
/** @hidden */
6969
static reportIdAttribute = 'powerbi-report-id';
7070
/** @hidden */

src/util.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ export async function isSavedInternal(hpm: HttpPostMessage, uid: string, content
174174
* @returns {boolean}
175175
*/
176176
export function isRDLEmbed(embedUrl: string): boolean {
177-
return embedUrl.toLowerCase().indexOf("/rdlembed?") >= 0;
177+
return embedUrl && embedUrl.toLowerCase().indexOf("/rdlembed?") >= 0;
178178
}
179179

180180
/**

0 commit comments

Comments
 (0)