Support ~login for MentionFilter and add more test for mentioned user.

Author: JuanitoFatas

lib/html/pipeline/@mention_filter.rb

@@ -125,11 +125,17 @@ def link_to_mention_info(text, info_url=nil)
 
       def link_to_mentioned_user(login)
         result[:mentioned_usernames] |= [login]
-        url = File.join(base_url, login)
-        "<a href='#{url}' class='user-mention'>" +
+
+        if base_url.last == '~' && base_url.last(2) != '/~'
+          base_url.prepend("/")
+        else
+          base_url << "/" unless base_url.last =~ /\/|~/
+        end
+
+        "<a href='#{base_url << login}' class='user-mention'>" +
         "@#{login}" +
         "</a>"
       end
     end
   end
-end
+end

test/html/pipeline/mention_filter_test.rb

@@ -72,6 +72,34 @@ def test_links_to_more_info_when_info_url_given
       filter(body, '/', 'https://github.com/blog/821').to_html
   end
 
+  def test_base_url_slash
+    body = "<p>Hi, @jch!</p>"
+    link = "<a href=\"/jch\" class=\"user-mention\">@jch</a>"
+    assert_equal "<p>Hi, #{link}!</p>",
+      filter(body, '/').to_html
+  end
+
+  def test_base_url_under_custom_route
+    body = "<p>Hi, @jch!</p>"
+    link = "<a href=\"/userprofile/jch\" class=\"user-mention\">@jch</a>"
+    assert_equal "<p>Hi, #{link}!</p>",
+      filter(body, '/userprofile').to_html
+  end
+
+  def test_base_url_tilde
+    body = "<p>Hi, @jch!</p>"
+    link = "<a href=\"/~jch\" class=\"user-mention\">@jch</a>"
+    assert_equal "<p>Hi, #{link}!</p>",
+      filter(body, '~').to_html
+  end
+
+  def test_base_url_slash_with_tilde
+    body = "<p>Hi, @jch!</p>"
+    link = "<a href=\"/~jch\" class=\"user-mention\">@jch</a>"
+    assert_equal "<p>Hi, #{link}!</p>",
+      filter(body, '/~').to_html
+  end
+
   MarkdownPipeline =
     HTML::Pipeline.new [
       HTML::Pipeline::MarkdownFilter,