Skip to content

Commit

Permalink
Merge pull request slackhq#121 from slackhq/txq-err
Browse files Browse the repository at this point in the history
Make linux tx queue length an error log instead of a fatal on error
  • Loading branch information
nbrownus authored Dec 20, 2019
2 parents fe58ced + 9db16d2 commit fe8a71e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tun_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ func (c Tun) Activate() error {
// Set the transmit queue length
ifrq := ifreqQLEN{Name: devName, Value: int32(c.TXQueueLen)}
if err = ioctl(fd, unix.SIOCSIFTXQLEN, uintptr(unsafe.Pointer(&ifrq))); err != nil {
return fmt.Errorf("failed to set tun tx queue length: %s", err)
// If we can't set the queue length nebula will still work but it may lead to packet loss
l.WithError(err).Error("Failed to set tun tx queue length")
}

// Bring up the interface
Expand Down

0 comments on commit fe8a71e

Please sign in to comment.