-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check for pending graphql generated items #9726
Comments
Hey @FelixMalfait , should I try working on this issue? |
@FelixMalfait Let me tell you how i approach this issue :- |
hey @FelixMalfait assign this issue ?? |
@yadavshubham01 feel free to raise a PR! Make sure to test it well before |
@FelixMalfait thanks |
This pull request addresses the issue of ensuring that npx nx run twenty-front:graphql:generate and npx nx run twenty-front:graphql:generate --configuration=metadata commands are run to generate the necessary GraphQL files. This prevents changes from being missed and ending up in subsequent unrelated PRs. Changes: Added a step in the ci-server.yml workflow to check for pending GraphQL generation. If any GraphQL changes are detected, the CI will fail, and an error message will be displayed instructing the developer to run the necessary commands and commit the changes. This approach is similar to the existing TypeORM migration check and helps maintain consistency and correctness in the codebase. Issue Resolved: #9726 --------- Co-authored-by: Charles Bochet <[email protected]>
Problem: people forget to run
npx nx run twenty-front:graphql:generate
andnpx nx run twenty-front:graphql:generate --configuration=metadata
. So sometimes their changes will end up in a subsequent unrelated PRWe had a similar problem for TypeORM which we solved elegantly: https://github.com/twentyhq/twenty/blob/main/.github/workflows/ci-server.yaml#L82
We should do the same for graphql generation
The text was updated successfully, but these errors were encountered: